hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4505) Hive can't load transforms added using 'ADD FILE'
Date Sat, 11 May 2013 07:37:17 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655187#comment-13655187
] 

Owen O'Malley commented on HIVE-4505:
-------------------------------------

Prasad, 

in Gunther's patch, Hive Server 2 will use the session handle for the handle identifier.

{code}
    // set an explicit session name to control the download directory name
    hiveConf.set(ConfVars.HIVESESSIONID.varname,
        sessionHandle.getHandleIdentifier().toString());
{code}

So there isn't an issue, right?

The use of finally has bad properties with respect to debugability because any exceptions
thrown out of the finally block (including ones like OOM or NPE) will hide the original exception.


The -f case is certainly a bug, still an improvement over the current trunk (or Hive 0.10)
behavior.

My inclination is to wait for the test cases that I launched this afternoon to finish and
roll the rc with Gunther's version of the patch tomorrow morning. We can file a follow up
jira with a refactoring of the CliDriver.run that doesn't have so many return points. *smile*

Does that sounds reasonable?


                
> Hive can't load transforms added using 'ADD FILE'
> -------------------------------------------------
>
>                 Key: HIVE-4505
>                 URL: https://issues.apache.org/jira/browse/HIVE-4505
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.11.0
>            Reporter: Prasad Mujumdar
>            Assignee: Prasad Mujumdar
>            Priority: Blocker
>             Fix For: 0.11.0
>
>         Attachments: HIVE-4505-1.patch, HIVE-4505.2.patch, HIVE-4505-3.patch
>
>
> ADD FILE mangles name of the resource when copying to resource download directory. As
a results following doesn't work:
> {code:sql}
> ADD FILE test.py;
> SELECT TRANSFORM (id) USING 'python test.py' AS b FROM tab1;
> {code}
> The resource gets added with a different name every time which makes it impossible to
use transform in non-interactive mode.
> This seems to be due to HIVE-3431

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message