hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remus Rusanu" <rem...@microsoft.com>
Subject Re: Review Request: HIVE-4612 Fix vector aggregates int type key output
Date Sat, 25 May 2013 13:51:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11427/
-----------------------------------------------------------

(Updated May 25, 2013, 1:51 p.m.)


Review request for hive.


Description
-------

The VectorHashKeyValue output for int key type was broken, the M/R expects the type emitted
to match the type reduced. By using a BinaryWriter with a LongWritable instead of a IntWritable
the value was effectively corrupted.


This addresses bug HIVE-4612.
    https://issues.apache.org/jira/browse/HIVE-4612


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/VectorHashKeyWrapperBatch.java c23614c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 1ef4955 

Diff: https://reviews.apache.org/r/11427/diff/


Testing
-------

manual test query


Thanks,

Remus Rusanu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message