hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remus Rusanu" <rem...@microsoft.com>
Subject Review Request: HIVE-4451 support COUNT/MIN/MAX aggregates on string types
Date Sat, 25 May 2013 11:28:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11425/
-----------------------------------------------------------

Review request for hive.


Description
-------

Vectorized COUNT is made type agnostic so it can support string types. Dedicated vectorized
MIN/MAX implementation for strings, based on the BytesVectorColumn.


This addresses bug HIVE-4451.
    https://issues.apache.org/jira/browse/HIVE-4451


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 1ef4955 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFCount.java
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFCountDouble.java
7a0c22b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFCountLong.java
c63892c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMaxString.java
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMinString.java
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/CodeGen.java 3ef2aa8

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFCount.txt
54c80ec 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFMinMaxString.txt
PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java b3b5cd2


Diff: https://reviews.apache.org/r/11425/diff/


Testing
-------

UT added, manually tested query in hive-cli


Thanks,

Remus Rusanu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message