hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Teddy Choi" <pudi...@gmail.com>
Subject Re: Review Request: HIVE-4548 Speed up vectorized LIKE filter for special cases abc%, %abc and %abc%
Date Tue, 21 May 2013 12:14:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11222/
-----------------------------------------------------------

(Updated May 21, 2013, 12:14 p.m.)


Review request for hive.


Changes
-------

The patch was fixed as Eric Hanson reviewed. It is written in correct code style. It has detailed
comments and unit tests.

Moreover, the capacity of a new byte buffer is now double of the requested capacity. It's
for further performance optimization.


Description
-------

I edited FilterStringColLikeStringScala.java as Eric Hanson wrote.

For none-complex patterns, it calls a static method that doesn't call others and uses its
given byte arrays only. For complex patterns, it reuses a ByteBuffer and a CharBuffer for
decoding UTF-8 to avoid object constructions.

There is 30%~170% performance improvement for all cases. Its benchmark result is on https://issues.apache.org/jira/browse/HIVE-4548#comment-13660750.

It still can be more efficient by using a template-driven approach. I'll apply it soon.


This addresses bug HIVE-4548.
    https://issues.apache.org/jira/browse/HIVE-4548


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java
24ba861 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java
6e26412 

Diff: https://reviews.apache.org/r/11222/diff/


Testing
-------


Thanks,

Teddy Choi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message