hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Hanson" <eh...@microsoft.com>
Subject Re: Review Request: HIVE-4548 Speed up vectorized LIKE filter for special cases abc%, %abc and %abc%
Date Fri, 17 May 2013 23:20:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11222/#review20736
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java
<https://reviews.apache.org/r/11222/#comment42827>

    Teddy,
    
    Overall this looks good!
    Because your code determines once per vector what special-case function to call, rather
than doing that in the inner loop, I don't think you need to create a templatized version
of this. That would not really significantly improve performance. 
    
    Please add additional unit tests to test your string pattern classification function and
test all the different types of patterns.
    
    Eric



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java
<https://reviews.apache.org/r/11222/#comment42828>

    Please put a comment to explain what this function does and why it is done that way.



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java
<https://reviews.apache.org/r/11222/#comment42822>

    comment start // has no comment after it



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java
<https://reviews.apache.org/r/11222/#comment42826>

    style guide says put blanks before/after = assignment operator.
    
    Please run ant checkstyle.
    
    Overall the style looks good though!


- Eric Hanson


On May 17, 2013, 2:36 p.m., Teddy Choi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11222/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 2:36 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Description
> -------
> 
> I edited FilterStringColLikeStringScala.java as Eric Hanson wrote.
> 
> For none-complex patterns, it calls a static method that doesn't call others and uses
its given byte arrays only. For complex patterns, it reuses a ByteBuffer and a CharBuffer
for decoding UTF-8 to avoid object constructions.
> 
> There is 30%~170% performance improvement for all cases. Its benchmark result is on https://issues.apache.org/jira/browse/HIVE-4548#comment-13660750.
> 
> It still can be more efficient by using a template-driven approach. I'll apply it soon.
> 
> 
> This addresses bug HIVE-4548.
>     https://issues.apache.org/jira/browse/HIVE-4548
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java
24ba861 
> 
> Diff: https://reviews.apache.org/r/11222/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Teddy Choi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message