hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Review Request: HIVE-4547: A complex create view statement fails with new Antlr 3.4
Date Mon, 13 May 2013 09:06:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11084/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Description
-------

The parser has a translation map where its possible to replace all the text with the appropriate
escaped version in case of a view creation. This holds all individual translations and where
they apply in the view definition.
The newer antlr version seems to be more restrictive and throws assertion if there's an overlaps
in these escape positions. The original patch for antlr upgrade added a check to take care
of some of the simpler overlap cases found by unit tests. There are few more scenarios like
the one in the customer case which are not covered.
The patch includes Traverse the list of translation in a loop and look for all the possible
overlaps.


This addresses bug HIVE-4547.
    https://issues.apache.org/jira/browse/HIVE-4547


Diffs
-----

  data/files/v1.txt PRE-CREATION 
  data/files/v2.txt PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java ec2c088 
  ql/src/test/queries/clientpositive/view_cast.q PRE-CREATION 
  ql/src/test/results/clientpositive/view_cast.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/11084/diff/


Testing
-------

Ran full test suite. 
Added new test.


Thanks,

Prasad Mujumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message