hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@gmail.com>
Subject Re: Review Request: Add support for vectorized string concatenation
Date Wed, 01 May 2013 09:01:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10868/#review19999
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColCol.java
<https://reviews.apache.org/r/10868/#comment41236>

    Shouldn't this be string?


- Timothy Chen


On April 30, 2013, 9:35 p.m., Eric Hanson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10868/
> -----------------------------------------------------------
> 
> (Updated April 30, 2013, 9:35 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Description
> -------
> 
> Add support for vectorized string concatenation
> 
> 
> This addresses bug HIVE-4431.
>     https://issues.apache.org/jira/browse/HIVE-4431
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java 246170d 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColCol.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColScalar.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatScalarCol.java
PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java
c0e71e5 
> 
> Diff: https://reviews.apache.org/r/10868/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eric Hanson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message