Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4DC20FB8F for ; Tue, 2 Apr 2013 23:23:16 +0000 (UTC) Received: (qmail 88063 invoked by uid 500); 2 Apr 2013 23:23:15 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 87992 invoked by uid 500); 2 Apr 2013 23:23:15 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 87983 invoked by uid 500); 2 Apr 2013 23:23:15 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 87980 invoked by uid 99); 2 Apr 2013 23:23:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Apr 2013 23:23:15 +0000 Date: Tue, 2 Apr 2013 23:23:15 +0000 (UTC) From: "Phabricator (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-4120) Implement decimal encoding for ORC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620402#comment-13620402 ] Phabricator commented on HIVE-4120: ----------------------------------- hagleitn has commented on the revision "HIVE-4120 [jira] Implement decimal encoding for ORC". Looks good to me. Only minor comment: It would be nice if there was an end to end test (i.e.: a .q file with an orc + decimal table. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java:438 no need to copy the bigdecimal for min, max and sum, they're immutable me thinks. REVISION DETAIL https://reviews.facebook.net/D9207 To: JIRA, omalley Cc: hagleitn > Implement decimal encoding for ORC > ---------------------------------- > > Key: HIVE-4120 > URL: https://issues.apache.org/jira/browse/HIVE-4120 > Project: Hive > Issue Type: New Feature > Components: Serializers/Deserializers > Reporter: Owen O'Malley > Assignee: Owen O'Malley > Attachments: HIVE-4120.D9207.1.patch > > > Currently, ORC does not have an encoder for decimal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira