Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Received-SPF: pass (athena.apache.org: domain of ghagleitner@hortonworks.com
 designates 209.85.128.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CABN7xTC9DNAZNneZR1rxkF458vok1tX1Vm8VafPA-E50sgh4cA@mail.gmail.com>
References: 
 <CABN7xTC9DNAZNneZR1rxkF458vok1tX1Vm8VafPA-E50sgh4cA@mail.gmail.com>
Date: Fri, 5 Apr 2013 15:11:44 -0700
Message-ID: 
 <CAGLR3Tz4VGrCpVqzAJyaY1u0wE5g1p7od+ip2yHK2OcSogvG1Q@mail.gmail.com>
Subject: Re: builtins submodule - is it still needed?
From: Gunther Hagleitner <ghagleitner@hortonworks.com>
To: dev@hive.apache.org
Cc: user@hive.apache.org
Content-Type: multipart/alternative; boundary=bcaec517a8be6305a204d9a45f7f

--bcaec517a8be6305a204d9a45f7f
Content-Type: text/plain; charset=ISO-8859-1

+1

I would actually go a step further and propose to remove both PDK and
builtins. I've went through the code for both and here is what I found:

Builtins:
- BuiltInUtils.java: Empty file
- UDAFUnionMap: Merges maps. Doesn't seem to be useful by itself, but was
intended as a building block for PDK

PDK:
- some helper build.xml/test setup + teardown scripts
- Classes/annotations to help run unit tests
- rot13 as an example

>From what I can tell it's a fair assessment that it hasn't taken off, last
commits to it seem to have happened more than 1.5 years ago.

Thanks,
Gunther.


On Thu, Apr 4, 2013 at 2:01 PM, Travis Crawford <traviscrawford@gmail.com>wrote:

> Hey hive gurus -
>
> Is the "builtins" hive submodule in use? The submodule was added in
> HIVE-2523 as a location for builtin-UDFs, but it appears to not have
> taken off. Any objections to removing it?
>
> DETAILS
>
> For HIVE-4278 I'm making some build changes for the HCatalog
> integration. The "builtins" submodule causes issues because it delays
> building until the packaging phase - so HCatalog can't depend on
> builtins, which it does transitively.
>
> While investigating a path forward I discovered the "builtins"
> submodule contains very little code, and likely could either go away
> entirely or merge into "ql", simplifying things both for users and
> developers.
>
> Thoughts? Can anyone with context help me understand "builtins", both
> in general and around its non-standard build? For your trouble I'll
> either make the submodule go away/merge into another submodule, or
> update the docs with what we learn.
>
> Thanks!
> Travis
>

--bcaec517a8be6305a204d9a45f7f--