Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3B0F10A72 for ; Sat, 27 Apr 2013 09:58:07 +0000 (UTC) Received: (qmail 15233 invoked by uid 500); 27 Apr 2013 09:58:07 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 14995 invoked by uid 500); 27 Apr 2013 09:58:05 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 14960 invoked by uid 99); 27 Apr 2013 09:58:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Apr 2013 09:58:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B37961C3940; Sat, 27 Apr 2013 09:58:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3005540700972788817==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-4373 - Hive Version returned by HiveDatabaseMetaData.getDatabaseProductVersion is incorrect From: "Thejas Nair" To: "Carl Steinbach" , "Thejas Nair" , "hive" Date: Sat, 27 Apr 2013 09:58:00 -0000 Message-ID: <20130427095800.22503.40999@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/10812/ X-Sender: "Thejas Nair" References: <20130427065916.22503.9953@reviews.apache.org> In-Reply-To: <20130427065916.22503.9953@reviews.apache.org> Reply-To: "Thejas Nair" --===============3005540700972788817== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 27, 2013, 6:59 a.m., Carl Steinbach wrote: > > common/src/scripts/saveVersion.sh, line 66 > > > > > > I think the output directory was correct to begin with. Please reve= rt. HiveVersionInfo is in org/apache/hive/common/util/, so this package-info.ja= va with the annotations expected by HiveVersionInfo needs to be in same pac= kage. Otherwise HiveVersionInfo will not work. Hence the change to move it to this dir. Please let me know if you disagree= . = > On April 27, 2013, 6:59 a.m., Carl Steinbach wrote: > > common/build.xml, line 29 > > > > > > This extra property is only referenced in one place. I think it wou= ld be cleaner to remove it. Changing that in new patch. - Thejas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10812/#review19822 ----------------------------------------------------------- On April 27, 2013, 2:53 a.m., Thejas Nair wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10812/ > ----------------------------------------------------------- > = > (Updated April 27, 2013, 2:53 a.m.) > = > = > Review request for hive. > = > = > Description > ------- > = > HIVE-4373 > = > = > This addresses bug HIVE-4373. > https://issues.apache.org/jira/browse/HIVE-4373 > = > = > Diffs > ----- > = > common/build.xml 731f26e = > common/src/scripts/saveVersion.sh a917d4a = > jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 3d1a969 = > jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java 938dd9a = > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.ja= va 18594cb = > = > Diff: https://reviews.apache.org/r/10812/diff/ > = > = > Testing > ------- > = > Unit test included. Also tested with remote HS2 server. > = > = > Thanks, > = > Thejas Nair > = > --===============3005540700972788817==--