Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1795F34A for ; Thu, 18 Apr 2013 08:50:16 +0000 (UTC) Received: (qmail 70458 invoked by uid 500); 18 Apr 2013 08:50:16 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 70287 invoked by uid 500); 18 Apr 2013 08:50:16 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 70248 invoked by uid 99); 18 Apr 2013 08:50:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Apr 2013 08:50:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1139B1C895F; Thu, 18 Apr 2013 08:50:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8979770544538649774==" MIME-Version: 1.0 Subject: Re: Review Request: New code for VectorizedRowBatch to form basis of vectorized query execution From: "Carl Steinbach" To: "hive" , "Eric Hanson" , "Carl Steinbach" Date: Thu, 18 Apr 2013 08:50:10 -0000 Message-ID: <20130418085010.4547.18617@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Carl Steinbach" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/10592/ X-Sender: "Carl Steinbach" References: <20130418012747.4547.92332@reviews.apache.org> In-Reply-To: <20130418012747.4547.92332@reviews.apache.org> Reply-To: "Carl Steinbach" --===============8979770544538649774== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10592/#review19379 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java These comments violate the coding conventions. ColumnVector and Vectori= zedRowBatch have the same problem. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java Move the constant 1.2 to a static final float and refer to it by name. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java Formatting ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java Please throw a runtime exception here instead of relying on asserts (wh= ich can be disabled). ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.ja= va Please correct the formatting issues in this file. - Carl Steinbach On April 18, 2013, 1:27 a.m., Eric Hanson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10592/ > ----------------------------------------------------------- > = > (Updated April 18, 2013, 1:27 a.m.) > = > = > Review request for hive. > = > = > Description > ------- > = > New code for VectorizedRowBatch to form basis of vectorized query executi= on > = > = > This addresses bug HIVE-4284. > https://issues.apache.org/jira/browse/HIVE-4284 > = > = > Diffs > ----- > = > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.jav= a PRE-CREATION = > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java PRE= -CREATION = > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DoubleColumnVector.ja= va PRE-CREATION = > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java= PRE-CREATION = > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.ja= va PRE-CREATION = > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatc= h.java PRE-CREATION = > = > Diff: https://reviews.apache.org/r/10592/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Eric Hanson > = > --===============8979770544538649774==--