hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4305) Use a single system for dependency resolution
Date Sun, 21 Apr 2013 19:51:16 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637633#comment-13637633
] 

Carl Steinbach commented on HIVE-4305:
--------------------------------------

bq. It contains native executables.

So does Hive. Please look around.

bq. It contains native libraries.

So does Hive. Please look around.

bq. It contains jni libraries.

I'm not sure what makes this different from the previous two cases, but will admit that you've
got me there.

bq. Moving to Maven would be making it better in the opinion of the majority of the development
community.

So you have already conducted a poll? How large was your sample size and what are the margins
of error? Can you please publish the questions that were used? Thanks.

bq. Certainly, I believe it is possible to make things worse with Maven.

How do we know that isn't going to happen here?

bq. I'm not a fan of how the Hadoop mavenization was done...

In your opinion what did they do wrong? It's starting to sound like there's more than a little
room for error when transitioning a project over to Maven. Maybe the Maven community would
benefit from having a best practices document that highlighted these potential pitfalls.


bq. ... and I deeply regret not taking the time to make it better as it went in.

It's not too late to fix it, right? You're a committer on that project, which along with your
extensive Maven knowledge puts you in an excellent position to lead this effort.

bq. ... but it was still better than the ant + ivy + maven ant tasks that we had ...

I think part of the problem with the original build was that you were using three components
(ant, ivy, maven ant tasks), when you only needed to use two (ant, ivy). Our build, especially
post-HCatalog merge, suffers from this same problem. This ticket was originally filed to track
the task of removing either Ivy or maven ant asks, but was quickly hijacked by people intent
on replacing everything with Maven. Owen, would it be OK with you if we return to the original
focus of this ticket and resolve it before again considering your proposal? This will also
give you time to strengthen your argument by fixing the bugs and design defects in Hadoop's
Maven build.

bq. If it hadn't been, it would have been rejected.

I hope you're joking.

bq. That said, in my experience most projects are better off with Maven builds than ant +
ivy + maven ant tasks.

What characteristics define a project that falls into the latter category, or did you mean
to say *all* instead of *most*?
                
> Use a single system for dependency resolution
> ---------------------------------------------
>
>                 Key: HIVE-4305
>                 URL: https://issues.apache.org/jira/browse/HIVE-4305
>             Project: Hive
>          Issue Type: Improvement
>          Components: Build Infrastructure, HCatalog
>            Reporter: Travis Crawford
>            Assignee: Carl Steinbach
>
> Both Hive and HCatalog use ant as their build tool. However, Hive uses ivy for dependency
resolution while HCatalog uses maven-ant-tasks. With the project merge we should converge
on a single tool for dependency resolution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message