hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roshan Naik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4300) ant thriftif generated code that is checkedin is not up-to-date
Date Tue, 16 Apr 2013 18:15:18 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633119#comment-13633119
] 

Roshan Naik commented on HIVE-4300:
-----------------------------------

FYI.. HIVE-4322 makes manual changes to auto generated code. This will be a maintenance headache.
I have incorporated those changes into this as part of the rebasing in patch v2.

                
> ant thriftif  generated code that is checkedin is not up-to-date
> ----------------------------------------------------------------
>
>                 Key: HIVE-4300
>                 URL: https://issues.apache.org/jira/browse/HIVE-4300
>             Project: Hive
>          Issue Type: Bug
>          Components: Thrift API
>    Affects Versions: 0.10.0
>            Reporter: Roshan Naik
>            Assignee: Roshan Naik
>         Attachments: HIVE-4300.2.patch, HIVE-4300.patch
>
>
> running 'ant thriftif -Dthrift.home=/usr/local'  on a freshly checkedout trunk should
be a no-op as per [instructions|https://cwiki.apache.org/Hive/howtocontribute.html#HowToContribute-GeneratingThriftCode]
> However this is not the case. Some of files seem to be have been relocated or the classes
in them are now in a different file.
> Below is the git status showing the state after the command is run:
> # On branch trunk
> # Changes not staged for commit:
> #   (use "git add/rm <file>..." to update what will be committed)
> #   (use "git checkout -- <file>..." to discard changes in working directory)
> #
> #	modified:   build.properties
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SkewedInfo.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java
> #	modified:   metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
> #	deleted:    metastore/src/gen/thrift/gen-php/ThriftHiveMetastore.php
> #	deleted:    metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
> #	deleted:    metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php
> #	deleted:    metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_types.php
> #	deleted:    metastore/src/gen/thrift/gen-php/hive_metastore_constants.php
> #	deleted:    metastore/src/gen/thrift/gen-php/hive_metastore_types.php
> #	modified:   metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
> #	deleted:    ql/src/gen/thrift/gen-php/queryplan/queryplan_types.php
> #	modified:   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/InnerStruct.java
> #	modified:   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
> #	modified:   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
> #	modified:   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/IntString.java
> #	modified:   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
> #	modified:   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MiniStruct.java
> #	deleted:    serde/src/gen/thrift/gen-php/serde/serde_constants.php
> #	deleted:    serde/src/gen/thrift/gen-php/serde/serde_types.php
> #	deleted:    service/src/gen/thrift/gen-php/hive_service/ThriftHive.php
> #	deleted:    service/src/gen/thrift/gen-php/hive_service/hive_service_types.php
> #	modified:   service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote
> #	modified:   service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote
> #
> # Untracked files:
> #   (use "git add <file>..." to include in what will be committed)
> #
> #	serde/src/gen/thrift/gen-cpp/complex_constants.cpp
> #	serde/src/gen/thrift/gen-cpp/complex_constants.h
> #	serde/src/gen/thrift/gen-cpp/complex_types.cpp
> #	serde/src/gen/thrift/gen-cpp/complex_types.h
> #	serde/src/gen/thrift/gen-cpp/megastruct_constants.cpp
> #	serde/src/gen/thrift/gen-cpp/megastruct_constants.h
> #	serde/src/gen/thrift/gen-cpp/megastruct_types.cpp
> #	serde/src/gen/thrift/gen-cpp/megastruct_types.h
> #	serde/src/gen/thrift/gen-cpp/testthrift_constants.cpp
> #	serde/src/gen/thrift/gen-cpp/testthrift_constants.h
> #	serde/src/gen/thrift/gen-cpp/testthrift_types.cpp
> #	serde/src/gen/thrift/gen-cpp/testthrift_types.h
> #	serde/src/gen/thrift/gen-php/Types.php
> #	serde/src/gen/thrift/gen-py/complex/
> #	serde/src/gen/thrift/gen-py/megastruct/
> #	serde/src/gen/thrift/gen-py/testthrift/
> #	serde/src/gen/thrift/gen-rb/complex_constants.rb
> #	serde/src/gen/thrift/gen-rb/complex_types.rb
> #	serde/src/gen/thrift/gen-rb/megastruct_constants.rb
> #	serde/src/gen/thrift/gen-rb/megastruct_types.rb
> #	serde/src/gen/thrift/gen-rb/testthrift_constants.rb
> #	serde/src/gen/thrift/gen-rb/testthrift_types.rb

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message