hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4130) Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs
Date Mon, 15 Apr 2013 17:34:18 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631911#comment-13631911
] 

Phabricator commented on HIVE-4130:
-----------------------------------

ashutoshc has requested changes to the revision "HIVE-4130 [jira] Bring the Lead/Lag UDFs
interface in line with Lead/Lag UDAFs".

  Mostly looks good. Some comments.

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java:60 This catch block
is no longer required I think. Now that we ascertain arguments.length > 1 there cant be
NPE here.
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java:66 Bit confused
here. In case of this exception, isnt it better to just throw exception, instead of setting
amt to max. What do you think?
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java:113 This can be
removed. We have same code down below.

REVISION DETAIL
  https://reviews.facebook.net/D10233

BRANCH
  HIVE-4130

ARCANIST PROJECT
  hive

To: JIRA, ashutoshc, hbutani

                
> Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs
> -------------------------------------------------------------
>
>                 Key: HIVE-4130
>                 URL: https://issues.apache.org/jira/browse/HIVE-4130
>             Project: Hive
>          Issue Type: Bug
>          Components: PTF-Windowing
>            Reporter: Harish Butani
>            Assignee: Harish Butani
>         Attachments: HIVE-4130.D10233.1.patch
>
>
> - support a default value arg
> - both amt and defaultValue args can be optional

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message