hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4067) Followup to HIVE-701: reduce ambiguity in grammar
Date Fri, 05 Apr 2013 03:38:16 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623320#comment-13623320
] 

Hudson commented on HIVE-4067:
------------------------------

Integrated in Hive-trunk-h0.21 #2046 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2046/])
    HIVE-4067 : Followup to HIVE-701: reduce ambiguity in grammar (Samuel Yuan via Ashutosh
Chauhan) (Revision 1464808)

     Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1464808
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g
* /hive/trunk/ql/src/test/queries/clientpositive/nonreserved_keywords_insert_into1.q
* /hive/trunk/ql/src/test/results/clientpositive/nonreserved_keywords_insert_into1.q.out
* /hive/trunk/ql/src/test/results/compiler/errors/wrong_distinct2.q.out

                
> Followup to HIVE-701: reduce ambiguity in grammar
> -------------------------------------------------
>
>                 Key: HIVE-4067
>                 URL: https://issues.apache.org/jira/browse/HIVE-4067
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.11.0
>            Reporter: Samuel Yuan
>            Assignee: Samuel Yuan
>            Priority: Minor
>             Fix For: 0.11.0
>
>         Attachments: HIVE-4067.D8883.1.patch, HIVE-4067.HIVE-4067.HIVE-4067.HIVE-4067.D8883.2.patch
>
>
> After HIVE-701 the grammar has become much more ambiguous, and the compilation generates
a large number of warnings. Making FROM, DISTINCT, PRESERVE, COLUMN, ALL, AND, OR, and NOT
reserved keywords again reduces the number of warnings to 134, up from the original 81 warnings
but down from the 565 after HIVE-701. Most of the remaining ambiguity is trivial, an example
being "KW_ELEM_TYPE | KW_KEY_TYPE | KW_VALUE_TYPE | identifier", and they are all correctly
handled by ANTLR.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message