hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-4067) Followup to HIVE-701: reduce ambiguity in grammar
Date Thu, 04 Apr 2013 03:53:25 GMT

     [ https://issues.apache.org/jira/browse/HIVE-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-4067:
------------------------------

    Attachment: HIVE-4067.HIVE-4067.HIVE-4067.HIVE-4067.D8883.2.patch

sxyuan updated the revision "HIVE-4067 [jira] Followup to HIVE-701: reduce ambiguity in grammar".

  Fix for error messages in grammar compilation.

Reviewers: kevinwilfong

REVISION DETAIL
  https://reviews.facebook.net/D8883

CHANGE SINCE LAST DIFF
  https://reviews.facebook.net/D8883?vs=28629&id=31041#toc

AFFECTED FILES
  ql/src/test/results/clientpositive/nonreserved_keywords_insert_into1.q.out
  ql/src/test/results/compiler/errors/wrong_distinct2.q.out
  ql/src/test/queries/clientpositive/nonreserved_keywords_insert_into1.q
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g

To: kevinwilfong, sxyuan
Cc: ashutoshc, JIRA

                
> Followup to HIVE-701: reduce ambiguity in grammar
> -------------------------------------------------
>
>                 Key: HIVE-4067
>                 URL: https://issues.apache.org/jira/browse/HIVE-4067
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.11.0
>            Reporter: Samuel Yuan
>            Assignee: Samuel Yuan
>            Priority: Minor
>         Attachments: HIVE-4067.D8883.1.patch, HIVE-4067.HIVE-4067.HIVE-4067.HIVE-4067.D8883.2.patch
>
>
> After HIVE-701 the grammar has become much more ambiguous, and the compilation generates
a large number of warnings. Making FROM, DISTINCT, PRESERVE, COLUMN, ALL, AND, OR, and NOT
reserved keywords again reduces the number of warnings to 134, up from the original 81 warnings
but down from the 565 after HIVE-701. Most of the remaining ambiguity is trivial, an example
being "KW_ELEM_TYPE | KW_KEY_TYPE | KW_VALUE_TYPE | identifier", and they are all correctly
handled by ANTLR.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message