Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 11 Mar 2013 16:35:16 +0000 (UTC)
From: "Phabricator (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12635421.1362513684487.419158.1363019716034@arcas>
In-Reply-To: <JIRA.12635421.1362513684487@arcas>
References: <JIRA.12635421.1362513684487@arcas>
Subject: [jira] [Commented] (HIVE-4125) Expose metastore JMX metrics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598962#comment-13598962 ] 

Phabricator commented on HIVE-4125:
-----------------------------------

sxyuan has commented on the revision "HIVE-4125 [jira] Expose metastore JMX metrics".

INLINE COMMENTS
  common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java:71 I considered doing that, but it's not a counter tracked by this class, only a metric calculated from the other two. I think it would be better to have whatever needs the average time to recalculate the value instead of getting it from the MetricsMBean (and having to wait for a lock on the metrics map).
  common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java:197-202 Done. I originally didn't want to be throwing exceptions but I realized it's possible for a call to be made on a new scope that hasn't been closed yet.

REVISION DETAIL
  https://reviews.facebook.net/D9123

To: kevinwilfong, sxyuan
Cc: JIRA

                
> Expose metastore JMX metrics
> ----------------------------
>
>                 Key: HIVE-4125
>                 URL: https://issues.apache.org/jira/browse/HIVE-4125
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.11.0
>            Reporter: Samuel Yuan
>            Assignee: Samuel Yuan
>            Priority: Trivial
>         Attachments: HIVE-4125.HIVE-4125.HIVE-4125.D9123.1.patch, HIVE-4125.HIVE-4125.HIVE-4125.D9123.2.patch
>
>
> Add a safe way to access the metrics stored for each MetricsScope, so that they can be used outside of JMX.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira