hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-4148) Cleanup aisle "ivy"
Date Fri, 15 Mar 2013 20:00:15 GMT

    [ https://issues.apache.org/jira/browse/HIVE-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603776#comment-13603776
] 

Carl Steinbach commented on HIVE-4148:
--------------------------------------

This patch is causing the build to fail on my machine.
I created HIVE-4187 to track this problem and assigned
it to Gunther.

I am able to fix the failure by adding antlr and antlr-runtime
back to ql/ivy.xml.

I think we should consider reverting this patch for the following
reasons:

* It makes maintenance harder since it converts explicit dependencies into transitive ones.
For example, hive-exec has a direct compile-time dependency on the antlr parser generator,
but it now relies on a transitive dependency via hive-metastore in order to satisfy this.
This is also brittle since it means that hive-exec will break if the antlr dependency is removed
from metastore/ivy.xml.
* I don't see any performance improvement with this change in place. I tried doing a fresh
build several times with and without HIVE-4148, and the version without HIVE-4148 often finishes
a couple seconds faster. This is pretty much what you would expect since Ivy should be using
its local cache to resolve most of these dependencies.

                
> Cleanup aisle "ivy"
> -------------------
>
>                 Key: HIVE-4148
>                 URL: https://issues.apache.org/jira/browse/HIVE-4148
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Gunther Hagleitner
>            Assignee: Gunther Hagleitner
>             Fix For: 0.11.0
>
>         Attachments: HIVE-4148.patch
>
>
> Lot's of duplicated dependencies in the modules' ivy configs. Makes compiling slow and
maintenance hard. This patch cleans up these dependencies.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message