hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikram Dixit K (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join
Date Fri, 01 Mar 2013 05:57:17 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590262#comment-13590262
] 

Vikram Dixit K commented on HIVE-3891:
--------------------------------------

I think all this needs is SizeBasedBigTableSelectorForAutoSMJ to have the following additional
snippet:

{noformat}

if (parentOp instanceof TableScanOperator) {
topOps.add(parentOp);

<b>else if (parentOp instanceof CommonJoinOperator) {
  return;
}
</b>
else {
...

{noformat}

We shouldn't be taking that operation all the way to the top of the operator tree which is
what is happening. Let me know what you think? 

Thanks
Vikram.
                
> physical optimizer changes for auto sort-merge join
> ---------------------------------------------------
>
>                 Key: HIVE-3891
>                 URL: https://issues.apache.org/jira/browse/HIVE-3891
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: auto_sortmerge_join_1.q, auto_sortmerge_join_1.q.out, hive.3891.1.patch,
hive.3891.2.patch, hive.3891.3.patch, hive.3891.4.patch, hive.3891.5.patch, hive.3891.6.patch,
hive.3891.7.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message