Return-Path: 
 <dev-return-47001-apmail-hive-dev-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-dev-archive@www.apache.org
Delivered-To: apmail-hive-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 0B38CEDA3
	for <apmail-hive-dev-archive@www.apache.org>;
 Sun, 24 Feb 2013 16:48:15 +0000 (UTC)
Received: (qmail 63982 invoked by uid 500); 24 Feb 2013 16:48:14 -0000
Delivered-To: apmail-hive-dev-archive@hive.apache.org
Received: (qmail 63898 invoked by uid 500); 24 Feb 2013 16:48:14 -0000
Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hive.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hive.apache.org>
List-Post: <mailto:dev@hive.apache.org>
List-Id: <dev.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list dev@hive.apache.org
Received: (qmail 63758 invoked by uid 500); 24 Feb 2013 16:48:14 -0000
Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org
Received: (qmail 63695 invoked by uid 99); 24 Feb 2013 16:48:14 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Feb 2013 16:48:14 +0000
Date: Sun, 24 Feb 2013 16:48:13 +0000 (UTC)
From: "Phabricator (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12633787.1361690311482.330090.1361724493911@arcas>
In-Reply-To: <JIRA.12633787.1361690311482@arcas>
References: <JIRA.12633787.1361690311482@arcas>
Subject: [jira] [Commented] (HIVE-4068) Size of aggregation buffer which
 uses non-primitive type is not estimated correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HIVE-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585414#comment-13585414 ] 

Phabricator commented on HIVE-4068:
-----------------------------------

njain has commented on the revision "HIVE-4068 [jira] Size of aggregation buffer which uses non-primitive type is not estimated correctly".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java:581 Instead of checking instanceof, can you add a annotation ?

REVISION DETAIL
  https://reviews.facebook.net/D8859

To: JIRA, navis
Cc: njain

                
> Size of aggregation buffer which uses non-primitive type is not estimated correctly
> -----------------------------------------------------------------------------------
>
>                 Key: HIVE-4068
>                 URL: https://issues.apache.org/jira/browse/HIVE-4068
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-4068.D8859.1.patch, HIVE-4068.D8859.2.patch
>
>
> Currently, hive assumes an aggregation buffer which holds a map is occupying just 256 byte (fixed). If it's bigger than that in real, OutOfMemoryError can be thrown (especially for >1k buffer). 
> workaround : set hive.map.aggr.hash.percentmemory=<smaller value than default(0.5)>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira