Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA9DFE92D for ; Mon, 11 Feb 2013 04:13:16 +0000 (UTC) Received: (qmail 10276 invoked by uid 500); 11 Feb 2013 04:13:16 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 10025 invoked by uid 500); 11 Feb 2013 04:13:15 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 9978 invoked by uid 500); 11 Feb 2013 04:13:14 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 9955 invoked by uid 99); 11 Feb 2013 04:13:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2013 04:13:13 +0000 Date: Mon, 11 Feb 2013 04:13:13 +0000 (UTC) From: "Arun A K (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-3850) hour() function returns 12 hour clock value when using timestamp datatype MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575613#comment-13575613 ] Arun A K commented on HIVE-3850: -------------------------------- Hello [~analog.sony] There is a patch already available with the suggested changes made, submitted by Mr. [~710154]. So what is the point in submitting the same patch again ? More over there is a pending review request for the same https://reviews.apache.org/r/9171/ . Request you to justify your act? Have you tried to include something different in the previous work? > hour() function returns 12 hour clock value when using timestamp datatype > ------------------------------------------------------------------------- > > Key: HIVE-3850 > URL: https://issues.apache.org/jira/browse/HIVE-3850 > Project: Hive > Issue Type: Bug > Components: UDF > Affects Versions: 0.9.0, 0.10.0 > Reporter: Pieterjan Vriends > Fix For: 0.11.0 > > Attachments: hive-3850.patch, HIVE-3850.patch.txt > > > Apparently UDFHour.java does have two evaluate() functions. One that does accept a Text object as parameter and one that does use a TimeStampWritable object as parameter. The first function does return the value of Calendar.HOUR_OF_DAY and the second one of Calendar.HOUR. In the documentation I couldn't find any information on the overload of the evaluation function. I did spent quite some time finding out why my statement didn't return a 24 hour clock value. > Shouldn't both functions return the same? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira