Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 80D71E37A for ; Sat, 9 Feb 2013 19:05:19 +0000 (UTC) Received: (qmail 16002 invoked by uid 500); 9 Feb 2013 19:05:19 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 15951 invoked by uid 500); 9 Feb 2013 19:05:19 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 15940 invoked by uid 99); 9 Feb 2013 19:05:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Feb 2013 19:05:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8C42E1C73C4; Sat, 9 Feb 2013 19:05:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7509637035907483910==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-3179: HBase Handler doesn't handle NULLs properly From: "Brock Noland" To: "Mark Grover" , "Lars Francke" , "hive" , "Brock Noland" Date: Sat, 09 Feb 2013 19:05:11 -0000 Message-ID: <20130209190511.13216.67115@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brock Noland" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/5542/ X-Sender: "Brock Noland" References: <20130208153339.13217.95558@reviews.apache.org> In-Reply-To: <20130208153339.13217.95558@reviews.apache.org> Reply-To: "Brock Noland" --===============7509637035907483910== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Feb. 8, 2013, 3:33 p.m., Mark Grover wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java, = line 127 > > > > > > Lars, I noticed that the Javadoc here is inconsistent with the meth= od signature. This is obviously unrelated to your change but if you have a = chance, could you please correct the Javadoc here? Mark, I agree we should update the javadoc, however I don't think that should hol= d up a commit since it's unrelated to this change and this issue is critica= l. That is if Lars doesn't update the patch we can address that issue in a = new JIRA. Would you agree? = Brock - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5542/#review16351 ----------------------------------------------------------- On June 25, 2012, 5:30 a.m., Lars Francke wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5542/ > ----------------------------------------------------------- > = > (Updated June 25, 2012, 5:30 a.m.) > = > = > Review request for hive. > = > = > Description > ------- > = > This patch moves the initialization of the fieldsInited variable to the e= nd of the loop because otherwise NULL values will return stale data on the = second iteration. All other cases should be unaffected by this change. = > = > = > This addresses bug HIVE-3179. > https://issues.apache.org/jira/browse/HIVE-3179 > = > = > Diffs > ----- > = > hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java d= 35bb52 = > hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject= .java f91be4c = > = > Diff: https://reviews.apache.org/r/5542/diff/ > = > = > Testing > ------- > = > Debugged problem, added code to existing test to force wrong behavior whi= ch is fixed by this patch, ran the hbase-handler unit tests > = > = > Thanks, > = > Lars Francke > = > --===============7509637035907483910==--