hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-3849) Aliased column in where clause for multi-groupby single reducer cannot be resolved
Date Fri, 01 Feb 2013 05:43:15 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568505#comment-13568505
] 

Phabricator commented on HIVE-3849:
-----------------------------------

njain has commented on the revision "HIVE-3849 [jira] Columns are not extracted for multi-groupby
single reducer case somtimes".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:3537 Do you think it would
be easier to change genAllExprNodeDesc to return
  Map<ASTNode, ExprNodeDesc> ?

  It might involve a change in TypeCheckProcFactory, but it will make it
  much more readable.
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:3548 nit: formatting
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:3569 Can you add correct
comments for this function ?

  The predicates will be removed from mapping if they are passed in keys
  ql/src/test/queries/clientpositive/groupby_multi_single_reducer3.q:8 It might be a good
idea to add a test where the grouping key is present in
  the where clause.

REVISION DETAIL
  https://reviews.facebook.net/D7713

To: JIRA, navis
Cc: njain

                
> Aliased column in where clause for multi-groupby single reducer cannot be resolved
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-3849
>                 URL: https://issues.apache.org/jira/browse/HIVE-3849
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-3849.D7713.1.patch, HIVE-3849.D7713.2.patch, HIVE-3849.D7713.3.patch,
HIVE-3849.D7713.4.patch, HIVE-3849.D7713.5.patch, HIVE-3849.D7713.6.patch
>
>
> Verifying HIVE-3847, I've found an exception is thrown before meeting the error situation
described in it. Something like, 
> FAILED: SemanticException [Error 10025]: Line 40:6 Expression not in GROUP BY key 'crit5'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message