hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2843) UDAF to convert an aggregation to a map
Date Thu, 21 Feb 2013 06:06:13 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582947#comment-13582947
] 

Phabricator commented on HIVE-2843:
-----------------------------------

njain has commented on the revision "HIVE-2843 [jira] UDAF to convert an aggregation to a
map".

INLINE COMMENTS
  ql/src/test/queries/clientpositive/implode_to_map.q:2 The code changes look good.

  Some minor comments:

  1. Can you add

  describe implode_to_map and desc extended in the test ?

  2. Have you run all the tests ? I think you need to update show_functions.q.out
  ql/src/test/queries/clientpositive/implode_to_map.q:24 can you add some comments here -
what is the implode_to_map returning ?

  Add a test where the 2nd arg to implode_to_map is a primitive type
  ql/src/test/queries/clientpositive/implode_to_ordered_map.q:25 same as above.

REVISION DETAIL
  https://reviews.facebook.net/D8745

To: JIRA, navis
Cc: njain

                
> UDAF to convert an aggregation to a map
> ---------------------------------------
>
>                 Key: HIVE-2843
>                 URL: https://issues.apache.org/jira/browse/HIVE-2843
>             Project: Hive
>          Issue Type: New Feature
>          Components: UDF
>    Affects Versions: 0.9.0, 0.10.0
>            Reporter: David Worms
>            Priority: Minor
>              Labels: features, udf
>         Attachments: HIVE-2843.1.patch.txt, HIVE-2843.D8745.1.patch
>
>
> I propose the addition of two new Hive UDAF to help with maps in Apache Hive. The source
code is available on GitHub at https://github.com/wdavidw/hive-udf in two Java classes: "UDAFToMap"
and "UDAFToOrderedMap". The first function convert an aggregation into a map and is internally
using a Java `HashMap`. The second function extends the first one. It convert an aggregation
into an ordered map and is internally using a Java `TreeMap`. They both extends the `AbstractGenericUDAFResolver`
class.
> Also, I have covered the motivations and usages of those UDAF in a blog post at http://adaltas.com/blog/2012/03/06/hive-udaf-map-conversion/
> The full patch is available with tests as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message