hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Review Request: HIVE-3995 PostgreSQL upgrade scripts are not valid
Date Thu, 07 Feb 2013 02:00:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9349/
-----------------------------------------------------------

Review request for hive.


Description
-------

I found issues in three files:

* 010-HIVE-3072.postgres.sql

Just escaping double quotes were missing.

* 011-HIVE-3649.postgres.sql

This alter statement tries to add new "not null" column without any default value. The statement
will fail if the table already contains some data. I've checked similar script in mysql/ folder
and that script is allowing null values. Thus I've allowed null values also here.

* 012-HIVE-1362.postgres

Just syntax fixes.


This addresses bug HIVE-3995.
    https://issues.apache.org/jira/browse/HIVE-3995


Diffs
-----

  /trunk/metastore/scripts/upgrade/postgres/010-HIVE-3072.postgres.sql 1443292 
  /trunk/metastore/scripts/upgrade/postgres/011-HIVE-3649.postgres.sql 1443292 
  /trunk/metastore/scripts/upgrade/postgres/012-HIVE-1362.postgres.sql 1443292 

Diff: https://reviews.apache.org/r/9349/diff/


Testing
-------

I've tested the upgrade scripts by loading file hive-schema-0.9.0.postgres.sql with some data
and executing upgrade-0.9.0-to-0.10.0.postgres.sql on top of that.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message