Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 21 Jan 2013 07:06:14 +0000 (UTC)
From: "Phabricator (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12607571.1347601376635.167101.1358751974400@arcas>
In-Reply-To: <JIRA.12607571.1347601376635@arcas>
References: <JIRA.12607571.1347601376635@arcas>
Subject: [jira] [Commented] (HIVE-3464) Merging join tree may reorder joins
 which could be invalid
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558577#comment-13558577 ] 

Phabricator commented on HIVE-3464:
-----------------------------------

njain has commented on the revision "HIVE-3464 [jira] Merging join tree may reorder joins which could be invalid".

INLINE COMMENTS
  ql/src/test/queries/clientpositive/mergejoins_mixed.q:19 I am totally confused.

  What is the diff. between the above query and the first query in
  (((a-b)-c)-d)
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:6273 Can you write a small wiki/note on that explaining the correct behavior ?
  This is very difficult to review otherwise.

REVISION DETAIL
  https://reviews.facebook.net/D5409

To: JIRA, navis
Cc: njain

                
> Merging join tree may reorder joins which could be invalid
> ----------------------------------------------------------
>
>                 Key: HIVE-3464
>                 URL: https://issues.apache.org/jira/browse/HIVE-3464
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Navis
>            Assignee: Navis
>         Attachments: HIVE-3464.D5409.2.patch, HIVE-3464.D5409.3.patch
>
>
> Currently, hive merges join tree from right to left regardless of join types, which may introduce join reordering. For example,
> select * from a join a b on a.key=b.key join a c on b.key=c.key join a d on a.key=d.key; 
> Hive tries to merge join tree in a-d=b-d, a-d=a-b, b-c=a-b order and a-d=a-b and b-c=a-b will be merged. Final join tree is "a-(bdc)".
> With this, ab-d join will be executed prior to ab-c. But if join type of -c and -d is different, this is not valid.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira