Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7184BEED3 for ; Wed, 9 Jan 2013 10:24:58 +0000 (UTC) Received: (qmail 84126 invoked by uid 500); 9 Jan 2013 10:24:53 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 83915 invoked by uid 500); 9 Jan 2013 10:24:53 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 83811 invoked by uid 500); 9 Jan 2013 10:24:52 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 83233 invoked by uid 99); 9 Jan 2013 10:24:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jan 2013 10:24:52 +0000 Date: Wed, 9 Jan 2013 10:24:51 +0000 (UTC) From: "Hudson (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-3000) Potential infinite loop / log spew in ZookeeperHiveLockManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547877#comment-13547877 ] Hudson commented on HIVE-3000: ------------------------------ Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-3000 Potential infinite loop / log spew in ZookeeperHiveLockManager (njain via kevinwilfong) (Revision 1335106) Result = ABORTED kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335106 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > Potential infinite loop / log spew in ZookeeperHiveLockManager > -------------------------------------------------------------- > > Key: HIVE-3000 > URL: https://issues.apache.org/jira/browse/HIVE-3000 > Project: Hive > Issue Type: Bug > Components: Locking > Affects Versions: 0.9.0 > Reporter: Paul Yang > Assignee: Namit Jain > Fix For: 0.10.0 > > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-3000.D3063.1.patch > > > See ZookeeperHiveLockManger.lock() > If Zookeeper is in a bad state, it's possible to get an exception (e.g. org.apache.zookeeper.KeeperException$SessionExpiredException) when we call lockPrimitive(). There is a bug in the exception handler where the loop does not exit because the break in the switch statement gets out the switch, not the do..while loop. Because tryNum was not incremented due to the exception, lockPrimitive() will be called in an infinite loop, as fast as possible. Since the exception is printed for each call, Hive will produce significant log spew. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira