hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-3921) recursive_dir.q fails on 0.23
Date Sun, 20 Jan 2013 20:28:14 GMT

     [ https://issues.apache.org/jira/browse/HIVE-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-3921:
------------------------------

    Attachment: HIVE-3921.D8055.1.patch

khorgath requested code review of "HIVE-3921 [jira] recursive_dir.q fails on 0.23".
Reviewers: JIRA

  Setting hive.mapred.supports.subdirectories to true to make test pass

  This test fails in 0.23

  	It insists that hive.mapred.supports.subdirectories must be true for mapred.input.dir.recursive
to be used. Currently, HiveConf sets that as false.
  	HIVE-3643 mentions param and says that once HIVE-3276 is in, we should switch the param,
and this jira has been committed.
  	Testing with just setting that parameter in the .q file yeilds a mismatch with the golden
file, but one that looks like it should just update the .out file:

      [junit] diff -a /Users/sush/dev/hive.git/build/ql/test/logs/clientpositive/recursive_dir.q.out
/Users/sush/dev/hive.git/ql/src/test/results/clientpositive/recursive_dir.q.out
      [junit] 59d58
      [junit] < PREHOOK: Input: default@fact_daily
      [junit] 64d62
      [junit] < POSTHOOK: Input: default@fact_daily

TEST PLAN
  Patch provided is a test change

REVISION DETAIL
  https://reviews.facebook.net/D8055

AFFECTED FILES
  ql/src/test/queries/clientpositive/recursive_dir.q
  ql/src/test/results/clientpositive/recursive_dir.q.out

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/19413/

To: JIRA, khorgath

                
> recursive_dir.q fails on 0.23
> -----------------------------
>
>                 Key: HIVE-3921
>                 URL: https://issues.apache.org/jira/browse/HIVE-3921
>             Project: Hive
>          Issue Type: Bug
>          Components: Tests
>         Environment: Hadoop 0.23 (2.0.2-alpha)
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>            Priority: Minor
>              Labels: 0.23, tests
>         Attachments: HIVE-3921.D8055.1.patch
>
>
> This test fails in 0.23
> 	- It insists that hive.mapred.supports.subdirectories must be true for mapred.input.dir.recursive
to be used. Currently, HiveConf sets that as false. 
> 	- HIVE-3643 mentions param and says that once HIVE-3276 is in, we should switch the
param, and this jira has been committed.
> 	- Testing with just setting that parameter in the .q file yeilds a mismatch with the
golden file, but one that looks like it should just update the .out file:
>     [junit] diff -a /Users/sush/dev/hive.git/build/ql/test/logs/clientpositive/recursive_dir.q.out
/Users/sush/dev/hive.git/ql/src/test/results/clientpositive/recursive_dir.q.out
>     [junit] 59d58
>     [junit] < PREHOOK: Input: default@fact_daily
>     [junit] 64d62
>     [junit] < POSTHOOK: Input: default@fact_daily

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message