hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-3904) Replace hashmaps in JoinOperators to array
Date Wed, 16 Jan 2013 12:20:13 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554975#comment-13554975
] 

Phabricator commented on HIVE-3904:
-----------------------------------

navis has commented on the revision "HIVE-3904 [jira] Replace hashmaps in JoinOperators to
array".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java:212 I didn't check the
use cases precisely but certainly, there is a case some element of array is null. For map,
it does not have null value (if not added explicitly) but for array it can have a null when
index is pos for driving alias.

REVISION DETAIL
  https://reviews.facebook.net/D7959

To: JIRA, navis
Cc: njain

                
> Replace hashmaps in JoinOperators to array
> ------------------------------------------
>
>                 Key: HIVE-3904
>                 URL: https://issues.apache.org/jira/browse/HIVE-3904
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-3904.D7959.1.patch
>
>
> Join operator has many HashMaps that maps tag to some internal value(ExprEvals, OIs,
etc.) and theses are accessed 5 or more times per an object, which is seemed unnecessary overhead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message