hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-3904) Replace hashmaps in JoinOperators to array
Date Wed, 16 Jan 2013 05:06:13 GMT

     [ https://issues.apache.org/jira/browse/HIVE-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HIVE-3904:
------------------------------

    Attachment: HIVE-3904.D7959.1.patch

navis requested code review of "HIVE-3904 [jira] Replace hashmaps in JoinOperators to array".
Reviewers: JIRA

  DPAL-1960 Replace maps in JoinOperators to array

  Join operator has many HashMaps that maps tag to some internal value(ExprEvals, OIs, etc.)
and theses are accessed 5 or more times per an object, which is seemed unnecessary overhead.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D7959

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/SkewJoinHandler.java
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/19161/

To: JIRA, navis

                
> Replace hashmaps in JoinOperators to array
> ------------------------------------------
>
>                 Key: HIVE-3904
>                 URL: https://issues.apache.org/jira/browse/HIVE-3904
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-3904.D7959.1.patch
>
>
> Join operator has many HashMaps that maps tag to some internal value(ExprEvals, OIs,
etc.) and theses are accessed 5 or more times per an object, which is seemed unnecessary overhead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message