hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Grover (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-3850) hour() function returns 12 hour clock value when using timestamp datatype
Date Thu, 31 Jan 2013 16:21:13 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567763#comment-13567763
] 

Mark Grover commented on HIVE-3850:
-----------------------------------

It's all good, we were all new at some point:-)

Here is what I would do for the tests:
Developer Guide is a really good link to read on how unit tests work in Hive:
https://cwiki.apache.org/confluence/display/Hive/DeveloperGuide#DeveloperGuide-Unittestsanddebugging

Practically, unit tests take a long time to run on especially if you run it on 1 node (like
me), so for a minor change like this, I run only the tests that are impacted.

To figure that out what's impacted, I would do something like:
{code}
cd ql/src/test/queries
grep -ri "hour" *
{code}

For results under clientpositive, I would run something like:
{code}
ant test -Dtestcase=TestCliDriver -Dqfile=<comma separated list of .q files>
{code}

For results under clientnegative, I would run something like:
{code}
ant test TestNegativeCliDriver -Dqfile=<comma separated list of .q files>
{code}

If any of the above tests fail, it may legitimately be because of the bug fix, in which case,
you would want to update the test output. You can do that by using {{-Doverwrite=true}} at
the end of your commands. If the outputs, do need to get updated, please include those diffs
in the patch as well.

The committers would usually run the whole suite of tests (some times on faster clusters),
so don't be paranoid about testing all tests but of course, do you due-diligence about finding
all tests that may be impacted and making sure they run fine.

Hope this makes sense. If you have any further questions, please don't hesitate to ask. And,
thanks for working on this patch!
                
> hour() function returns 12 hour clock value when using timestamp datatype
> -------------------------------------------------------------------------
>
>                 Key: HIVE-3850
>                 URL: https://issues.apache.org/jira/browse/HIVE-3850
>             Project: Hive
>          Issue Type: Bug
>          Components: UDF
>    Affects Versions: 0.9.0, 0.10.0
>            Reporter: Pieterjan Vriends
>             Fix For: 0.11.0
>
>         Attachments: HIVE-3850.patch.txt
>
>
> Apparently UDFHour.java does have two evaluate() functions. One that does accept a Text
object as parameter and one that does use a TimeStampWritable object as parameter. The first
function does return the value of Calendar.HOUR_OF_DAY and the second one of Calendar.HOUR.
In the documentation I couldn't find any information on the overload of the evaluation function.
I did spent quite some time finding out why my statement didn't return a 24 hour clock value.
> Shouldn't both functions return the same?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message