hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Grover (JIRA)" <>
Subject [jira] [Commented] (HIVE-3850) hour() function returns 12 hour clock value when using timestamp datatype
Date Thu, 31 Jan 2013 04:49:13 GMT


Mark Grover commented on HIVE-3850:

Patch looks good to me.

Usually, I would ask for unit tests to be added with any change but given that it's a trivial
change, I would be ok without new tests. We should, however, make sure we update the existing
unit tests if needed.

Did you get a chance to run the unit tests (atleast the ones that use hour UDF) and make sure
no changes are required in their output?

> hour() function returns 12 hour clock value when using timestamp datatype
> -------------------------------------------------------------------------
>                 Key: HIVE-3850
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: UDF
>    Affects Versions: 0.9.0
>            Reporter: Pieterjan Vriends
>         Attachments: HIVE-3850.patch.txt
> Apparently does have two evaluate() functions. One that does accept a Text
object as parameter and one that does use a TimeStampWritable object as parameter. The first
function does return the value of Calendar.HOUR_OF_DAY and the second one of Calendar.HOUR.
In the documentation I couldn't find any information on the overload of the evaluation function.
I did spent quite some time finding out why my statement didn't return a 24 hour clock value.
> Shouldn't both functions return the same?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message