hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-3101) dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
Date Wed, 09 Jan 2013 10:25:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547883#comment-13547883
] 

Hudson commented on HIVE-3101:
------------------------------

Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/])
    HIVE-3101. Drop table rollback hook always called. (Ransom Hezhiqiang via egc) (Revision
1348523)

     Result = ABORTED
ecapriolo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1348523
Files : 
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java

                
> dropTable will all ways excute hook.rollbackDropTable whether drop table success or faild.
> ------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3101
>                 URL: https://issues.apache.org/jira/browse/HIVE-3101
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: ransom.hezhiqiang
>            Assignee: ransom.hezhiqiang
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3101.1.patch
>
>
> see  the codes:
>  boolean success = false;
>     try {
>       client.drop_table(dbname, name, deleteData);
>       if (hook != null) {
>         hook.commitDropTable(tbl, deleteData);
>       }
>     } catch (NoSuchObjectException e) {
>       if (!ignoreUknownTab) {
>         throw e;
>       }
>     } finally {
>       if (!success && (hook != null)) {
>         hook.rollbackDropTable(tbl);
>       }
>     }
> success  will always false, whether  the drop was success or faild.
> so it's a bug. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message