hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-1444) "hdfs" is hardcoded in few places in the code which inhibits use of other file systems
Date Wed, 09 Jan 2013 10:30:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548220#comment-13548220
] 

Hudson commented on HIVE-1444:
------------------------------

Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/])
    HIVE-1444: hdfs is hardcoded in few places in the code which inhibits use of other file
systems (ecapriolo via hashutosh) (Revision 1297808)

     Result = ABORTED
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297808
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java

                
> "hdfs" is hardcoded in few places in the code which inhibits use of other file systems
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-1444
>                 URL: https://issues.apache.org/jira/browse/HIVE-1444
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.3.0, 0.4.0, 0.4.1, 0.5.0, 0.6.0, 0.7.0
>         Environment: any
>            Reporter: Yuliya Feldman
>            Assignee: Edward Capriolo
>            Priority: Critical
>             Fix For: 0.9.0
>
>         Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-1444.D1839.1.patch, hive-1444.patch.txt
>
>
> In quite a few places "hdfs" is hardcoded, which is OK for majority of the cases, except
when it is not really hdfs, but s3 or any other file system.
> The place where it really breaks is:
> in ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java :
> method: private void applyConstraints(URI fromURI, URI toURI, Tree ast, boolean isLocal)
> First few lines are check for file system:
>     if (!fromURI.getScheme().equals("file")
>         && !fromURI.getScheme().equals("hdfs")) {
>       throw new SemanticException(ErrorMsg.INVALID_PATH.getMsg(ast,
>           "only \"file\" or \"hdfs\" file systems accepted"));
>     }
> "hdfs" is hardcoded. 
> I don't think you need to have this check at all as you are checking whether filesystem
is local or not later on anyway and in regards to non locla file system - if one would be
bad one you would get problems or have it look like local before you even come to "applyConstraints"
method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message