hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request: Add 'show version' command to Hive CLI
Date Tue, 15 Jan 2013 17:29:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8958/#review15348
-----------------------------------------------------------


Hi, looks good! A few comments below.


http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/8958/#comment33014>

    Is their a reason we just use the exceptions message? I feel we are losing valuable information
by eating the stack trace.



http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh
<https://reviews.apache.org/r/8958/#comment33015>

    Excuse me for my likely ignorance, but is ant setting the cwd variable?


- Brock Noland


On Jan. 15, 2013, 1:14 p.m., Zhuoluo Yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8958/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2013, 1:14 p.m.)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Description
> -------
> 
> We add a simple ddl grammar, called "show version".
> The version info is generated automatically while compiling.
> 
> 
> This addresses bug HIVE-1151.
>     https://issues.apache.org/jira/browse/HIVE-1151
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/build.xml 1433285 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/HiveVersionAnnotation.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
1433285 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
1433285 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
1433285 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
1433285 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
1433285 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowVersionDesc.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/util/HiveVersionInfo.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8958/diff/
> 
> 
> Testing
> -------
> 
> $hive
> Hive history file=/tmp/zhuoluo/hive_job_log_zhuoluo_201301152113_1633688174.txt
> hive> show version;
> OK
> 0.11.0-SNAPSHOT from 1432865 by zhuoluo on Tue Jan 15 20:58:42 CST 2013
> http://svn.apache.org/repos/asf/hive/trunk
> Time taken: 0.279 seconds, Fetched: 2 row(s)
> hive> 
> 
> 
> Thanks,
> 
> Zhuoluo Yang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message