hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arup Malakar (JIRA)" <>
Subject [jira] [Updated] (HIVE-3789) Patch HIVE-3648 causing the majority of unit tests to fail on branch 0.9
Date Tue, 18 Dec 2012 19:44:13 GMT


Arup Malakar updated HIVE-3789:

        Fix Version/s: 0.9.0
             Assignee: Arup Malakar
    Affects Version/s: 0.10.0
         Release Note: [HIVE-3789] Added resolvePath method in ProxyFileSystem, so that the
underlying filesystem resolvePath is not called. Fixed checkPath as well, since it was ignoring
the schema and authority of the path being passed.
               Status: Patch Available  (was: Open)

Trash.moveToAppropriateTrash calls resolvePath, whose implementation is in the actual FileSystem
behind ProxyFileSystem. resolvePath checks if the path being moved belongs to that filessystem
or not. This check fails since it sees the proxy schema( "pfile") in the path instead of its
own schema ("file"). Overriding resolvePath to call the checkPath in ProxyFileSystem, fixed
the problem.

Also the old implementation of checkPath was incorrect, as it throws away the schema/authority
being passed before calling super. It should check if they match the proxy schema/authority.

The problem here was that ProxyFileSystem contains the FileSystem as a class member and it
doesn't extend it. Because of this reason if a method in FileSystem calls another method in
it, the method in FileSystem gets called not the overriden method in ProxyFileSystem. In this
case resolvePath internally calls checkPath(), but the checkPath of RawFileSystem gets called
instead of the overridden checkPath() in ProxyFileSystem. 
> Patch HIVE-3648 causing the majority of unit tests to fail on branch 0.9
> ------------------------------------------------------------------------
>                 Key: HIVE-3789
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore, Tests
>    Affects Versions: 0.9.0, 0.10.0
>         Environment: Hadooop 0.23.5, JDK 1.6.0_31
>            Reporter: Chris Drome
>            Assignee: Arup Malakar
>             Fix For: 0.10.0, 0.9.0
> Rolling back to before this patch shows that the unit tests are passing, after the patch,
the majority of the unit tests are failing.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message