hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Grover (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2693) Add DECIMAL data type
Date Wed, 19 Dec 2012 18:31:13 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536251#comment-13536251
] 

Mark Grover commented on HIVE-2693:
-----------------------------------

Gunther, to answer your former question. Yes, the trick is to convert double(by default)->
String -> BigDecimal in the casting code. I just verified with my latest changes that cast(3.4
as decimal) gives the correct precise BigDecimal. An added benefit of this is that where clause
are now working. No quotes or literals required. Let me tidy up a few loose ends and I will
post the patch up.

About your latest patch, thanks for the testing more. I agree that we should use compareTo
over equals. There is another place where equals() is being used in PrimitiveObjectInspectorUtils.java
I will change that to compareTo() in my next patch. Was the nasty bug you are referring to
related to equals/compareTo inconsistency?

Thanks again, patch coming soon.
                
> Add DECIMAL data type
> ---------------------
>
>                 Key: HIVE-2693
>                 URL: https://issues.apache.org/jira/browse/HIVE-2693
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor, Types
>    Affects Versions: 0.10.0
>            Reporter: Carl Steinbach
>            Assignee: Prasad Mujumdar
>         Attachments: 2693_7.patch, 2693_8.patch, 2693_fix_all_tests1.patch, HIVE-2693-10.patch,
HIVE-2693-11.patch, HIVE-2693-12-SortableSerDe.patch, HIVE-2693-13.patch, HIVE-2693-14.patch,
HIVE-2693-1.patch.txt, HIVE-2693-all.patch, HIVE-2693-fix.patch, HIVE-2693.patch, HIVE-2693-take3.patch,
HIVE-2693-take4.patch
>
>
> Add support for the DECIMAL data type. HIVE-2272 (TIMESTAMP) provides a nice template
for how to do this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message