hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Grover (JIRA)" <>
Subject [jira] [Commented] (HIVE-2693) Add DECIMAL data type
Date Tue, 18 Dec 2012 19:30:16 GMT


Mark Grover commented on HIVE-2693:

Ok, took a better look at a patch 12. Looks good overall.
On second thought, radix 10 is good for now. I am not going to vouch for unnecessary optimization
unless there is evidence that we need to. 

1. I understand the intent of +/- 2 you are doing to the sign bit. Is that really necessary?
Sure, you can have a sign that is the same as terminator but the terminator is not considered
until you get to the variable length part. What do you think?
2. Were you able to test out your serialization and deserialization code? We should make sure
it works the way we expect? Do you need some help with testing that?

So, once we can fix the issues I mentioned in the previous comment (where clauses, deterministic
order by), we should be good to review and post.
Thanks again!
> Add DECIMAL data type
> ---------------------
>                 Key: HIVE-2693
>                 URL:
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor, Types
>    Affects Versions: 0.10.0
>            Reporter: Carl Steinbach
>            Assignee: Prasad Mujumdar
>         Attachments: 2693_7.patch, 2693_8.patch, 2693_fix_all_tests1.patch, HIVE-2693-10.patch,
HIVE-2693-11.patch, HIVE-2693-12-SortableSerDe.patch, HIVE-2693-13.patch, HIVE-2693-1.patch.txt,
HIVE-2693-all.patch, HIVE-2693-fix.patch, HIVE-2693.patch, HIVE-2693-take3.patch, HIVE-2693-take4.patch
> Add support for the DECIMAL data type. HIVE-2272 (TIMESTAMP) provides a nice template
for how to do this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message