Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DCCDED584 for ; Wed, 7 Nov 2012 00:47:42 +0000 (UTC) Received: (qmail 88181 invoked by uid 500); 7 Nov 2012 00:47:42 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 88121 invoked by uid 500); 7 Nov 2012 00:47:42 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 88104 invoked by uid 99); 7 Nov 2012 00:47:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Nov 2012 00:47:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 978D71C482E; Wed, 7 Nov 2012 00:47:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3663142243877721557==" MIME-Version: 1.0 Subject: Re: Review Request: Include Table information in Hive's AddPartitionEvent From: "Mithun Radhakrishnan" To: "Francis Liu" , "Ashutosh Chauhan" Cc: "Mithun Radhakrishnan" , "hive" Date: Wed, 07 Nov 2012 00:47:39 -0000 Message-ID: <20121107004739.24874.69832@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mithun Radhakrishnan" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/7910/ X-Sender: "Mithun Radhakrishnan" References: <20121107004733.24874.12592@reviews.apache.org> In-Reply-To: <20121107004733.24874.12592@reviews.apache.org> Reply-To: "Mithun Radhakrishnan" --===============3663142243877721557== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7910/ ----------------------------------------------------------- (Updated Nov. 7, 2012, 12:47 a.m.) Review request for hive, Ashutosh Chauhan and Francis Liu. Description ------- This has to do with a minor overhaul of the HCatalog notifications that we'= re attempting in HCATALOG-546. It is proposed that HCatalog's notifications (on Add/Drop of Partitions) pr= ovide details to identify the affected partitions. Using the Partition object in AddPartitionEvent, one is able to retrieve th= e values of the partition-keys and the name of the Table. However, the part= ition-keys themselves aren't available (since the Table instance isn't part= of the AddPartitionEvent). Adding the table-reference to the AddPartitionEvent and DropPartitionEvent = classes will expose all the info we need. (The alternative is to query the = metastore for the table's schema and use the partition-keys from there. :/) Diffs ----- http://svn.apache.org/repos/asf/hive/branches/branch-0.9/metastore/src/ja= va/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1405924 = http://svn.apache.org/repos/asf/hive/branches/branch-0.9/metastore/src/ja= va/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java 1405924 = http://svn.apache.org/repos/asf/hive/branches/branch-0.9/metastore/src/ja= va/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java 1405924 = Diff: https://reviews.apache.org/r/7910/diff/ Testing ------- Thanks, Mithun Radhakrishnan --===============3663142243877721557==--