Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============0534827355702154659=="
MIME-Version: 1.0
Subject: Review Request: Include Table information in Hive's AddPartitionEvent
From: "Mithun Radhakrishnan" <mithun.radhakrishnan@yahoo.com>
To: "Francis Liu" <toffer@apache.org>,
 "Ashutosh Chauhan" <hashutosh@apache.org>
Cc: "Mithun Radhakrishnan" <mithun.radhakrishnan@yahoo.com>,
 "hive" <dev@hive.apache.org>
Date: Wed, 07 Nov 2012 00:47:33 -0000
Message-ID: <20121107004733.24874.12592@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Mithun Radhakrishnan" <noreply@reviews.apache.org>
Reply-To: "Mithun Radhakrishnan" <mithun.radhakrishnan@yahoo.com>

--===============0534827355702154659==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7910/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan and Francis Liu.


Description
-------

This has to do with a minor overhaul of the HCatalog notifications that we'=
re attempting in HCATALOG-546.
It is proposed that HCatalog's notifications (on Add/Drop of Partitions) pr=
ovide details to identify the affected partitions.
Using the Partition object in AddPartitionEvent, one is able to retrieve th=
e values of the partition-keys and the name of the Table. However, the part=
ition-keys themselves aren't available (since the Table instance isn't part=
 of the AddPartitionEvent).
Adding the table-reference to the AddPartitionEvent and DropPartitionEvent =
classes will expose all the info we need. (The alternative is to query the =
metastore for the table's schema and use the partition-keys from there. :/)


Diffs
-----

  http://svn.apache.org/repos/asf/hive/branches/branch-0.9/metastore/src/ja=
va/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1405924 =

  http://svn.apache.org/repos/asf/hive/branches/branch-0.9/metastore/src/ja=
va/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java 1405924 =

  http://svn.apache.org/repos/asf/hive/branches/branch-0.9/metastore/src/ja=
va/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java 1405924 =


Diff: https://reviews.apache.org/r/7910/diff/


Testing
-------


Thanks,

Mithun Radhakrishnan


--===============0534827355702154659==--