Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C693DD712 for ; Thu, 22 Nov 2012 06:53:05 +0000 (UTC) Received: (qmail 86972 invoked by uid 500); 22 Nov 2012 06:53:05 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 86911 invoked by uid 500); 22 Nov 2012 06:53:05 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 86863 invoked by uid 500); 22 Nov 2012 06:53:04 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 86856 invoked by uid 99); 22 Nov 2012 06:53:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Nov 2012 06:53:04 +0000 Date: Thu, 22 Nov 2012 06:53:04 +0000 (UTC) From: "Namit Jain (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <1650857345.16001.1353567184521.JavaMail.jiratomcat@arcas> In-Reply-To: <1302087907.3960.1333997958797.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HIVE-2935) Implement HiveServer2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502613#comment-13502613 ] Namit Jain commented on HIVE-2935: ---------------------------------- I haven't looked at the patch either, and I agree with Ashutosh, that additive portions (like beeline) can be checked in. However, would it be possible for you to break this patch, and extract the changes that you have made to the current hive code. That presents a huge risk, and should be reviewed very carefully. Or, you can take the other approach, which is to check in the new additive isolated components first (which will not be used), and then have the code which touches the current hive code in a patch. If someone is not using the hive server, what are the changes that this patch brings in ? That definitely needs to be reviewed very thoroughly. > Implement HiveServer2 > --------------------- > > Key: HIVE-2935 > URL: https://issues.apache.org/jira/browse/HIVE-2935 > Project: Hive > Issue Type: New Feature > Components: Server Infrastructure > Reporter: Carl Steinbach > Assignee: Carl Steinbach > Labels: HiveServer2 > Attachments: beelinepositive.tar.gz, HIVE-2935.1.notest.patch.txt, HIVE-2935.2.notest.patch.txt, HIVE-2935.2.nothrift.patch.txt > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira