hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pradeep Kamath (JIRA)" <>
Subject [jira] [Updated] (HIVE-3733) Improve Hive's logic for conditional merge
Date Mon, 26 Nov 2012 17:50:59 GMT


Pradeep Kamath updated HIVE-3733:

    Attachment: HIVE-3733.1.patch.txt

Attaching patch to fix the issue (used git diff --no-prefix ...). I tried using "arc diff
--jira HIVE-3733"
Got :
PHP Fatal error:  Call to undefined method ArcanistGitAPI::amendGitHeadCommit() in /Users/pradeepk/opensource-hive/.arc_jira_lib/arcanist/ArcJIRAConfiguration.php
on line 173

I saw some other references to this error in different JIRAs but no solution suggested - is
there a fix for this issue?

So I manually uploaded a diff (used git diff ..) to create the review -
> Improve Hive's logic for conditional merge
> ------------------------------------------
>                 Key: HIVE-3733
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: HIVE-3733.1.patch.txt
> If the config hive.merge.mapfiles is set to true and hive.merge.mapredfiles is set to
false then when hive encounters a FileSinkOperator when generating map reduce tasks, it will
look at the entire job to see if it has a reducer, if it does it will not merge. Instead it
should be check if the FileSinkOperator is a child of the reducer. This means that outputs
generated in the mapper will be merged, and outputs generated in the reducer will not be,
the intended effect of setting those configs.
> Simple repro:
> set hive.merge.mapfiles=true;
> set hive.merge.mapredfiles=false;
> FROM <input_table>
> INSERT OVERWRITE TABLE <output_table1> SELECT key, COUNT(*) group by key
> The output should contain a Conditional Operator, Mapred Stages, and Move tasks

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message