hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request: DB based token store
Date Tue, 13 Nov 2012 08:45:22 GMT


> On Nov. 13, 2012, 8:22 a.m., Prasad Mujumdar wrote:
> > The patch looks fine to me. 
> > Just wondering if the new table definitions should also be added to hive-schema-0.10.0.XXX.sql
files.
> >

Yeah definitely. My plan is to generate ddl files after all the schema changes are in. I guess
at this point only Shreepadma's work is left which deals with schema upgrade. Once thats get
in, then in a separate jira I will generate all the corresponding hive-0.10.0.XXX.sql files.
 


> On Nov. 13, 2012, 8:22 a.m., Prasad Mujumdar wrote:
> > trunk/metastore/scripts/upgrade/oracle/upgrate-0.9.0-to-0.10.0.oracle.sql, line
4
> > <https://reviews.apache.org/r/7941/diff/2/?file=188891#file188891line4>
> >
> >     It should include 010-HIVE-3649.oracle.sql as well ?

Yeah, missed that one. Will add that in.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7941/#review13387
-----------------------------------------------------------


On Nov. 12, 2012, 10:54 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7941/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 10:54 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Description
> -------
> 
> DB based token store
> 
> 
> This addresses bug HIVE-3255.
>     https://issues.apache.org/jira/browse/HIVE-3255
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/scripts/upgrade/derby/012-HIVE-3255.derby.sql PRE-CREATION 
>   trunk/metastore/scripts/upgrade/derby/upgrade-0.9.0-to-0.10.0.derby.sql 1408480 
>   trunk/metastore/scripts/upgrade/mysql/012-HIVE-3255.mysql.sql PRE-CREATION 
>   trunk/metastore/scripts/upgrade/mysql/upgrade-0.9.0-to-0.10.0.mysql.sql 1408480 
>   trunk/metastore/scripts/upgrade/oracle/012-HIVE-3255.oracle.sql PRE-CREATION 
>   trunk/metastore/scripts/upgrade/oracle/upgrate-0.9.0-to-0.10.0.oracle.sql PRE-CREATION

>   trunk/metastore/scripts/upgrade/postgres/012-HIVE-3255.postgres.sql PRE-CREATION 
>   trunk/metastore/scripts/upgrade/postgres/upgrade-0.9.0-to-0.10.0.postgres.sql 1408480

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1408480

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1408480

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1408480 
>   trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MDelegationToken.java
PRE-CREATION 
>   trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MMasterKey.java PRE-CREATION

>   trunk/metastore/src/model/package.jdo 1408480 
>   trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
1408480 
>   trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/DBTokenStore.java
PRE-CREATION 
>   trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/DelegationTokenStore.java
1408480 
>   trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
1408480 
>   trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/MemoryTokenStore.java
1408480 
>   trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java
1408480 
>   trunk/shims/src/common-secure/test/org/apache/hadoop/hive/thrift/TestDBTokenStore.java
PRE-CREATION 
>   trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java
1408480 
> 
> Diff: https://reviews.apache.org/r/7941/diff/
> 
> 
> Testing
> -------
> 
> Includes unit test
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message