hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pradeep Kamath (JIRA)" <>
Subject [jira] [Updated] (HIVE-3733) Improve Hive's logic for conditional merge
Date Thu, 29 Nov 2012 18:38:58 GMT


Pradeep Kamath updated HIVE-3733:

    Attachment: HIVE-3733.3.patch.txt

This is the most recent patch file - please review - I have also uploaded this to the review

A couple of unit tests fail:
1) testCliDriver_groupby_multi_single_reducer
This fails for me locally on trunk as well with a ClassNotFoundException for JSONFactory.
2) testNegativeCliDriver_stats_aggregator_error_1 
Apparently this one is known to be flakey.

Note that I needed to update union19.q.out to include the extra merge.

Please review - Thanks!
> Improve Hive's logic for conditional merge
> ------------------------------------------
>                 Key: HIVE-3733
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: HIVE-3733.1.patch.txt, HIVE-3733.3.patch.txt
> If the config hive.merge.mapfiles is set to true and hive.merge.mapredfiles is set to
false then when hive encounters a FileSinkOperator when generating map reduce tasks, it will
look at the entire job to see if it has a reducer, if it does it will not merge. Instead it
should be check if the FileSinkOperator is a child of the reducer. This means that outputs
generated in the mapper will be merged, and outputs generated in the reducer will not be,
the intended effect of setting those configs.
> Simple repro:
> set hive.merge.mapfiles=true;
> set hive.merge.mapredfiles=false;
> FROM <input_table>
> INSERT OVERWRITE TABLE <output_table1> SELECT key, COUNT(*) group by key
> The output should contain a Conditional Operator, Mapred Stages, and Move tasks

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message