Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E7A6DE2C for ; Fri, 19 Oct 2012 15:24:28 +0000 (UTC) Received: (qmail 11799 invoked by uid 500); 19 Oct 2012 15:24:27 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 11749 invoked by uid 500); 19 Oct 2012 15:24:27 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 11418 invoked by uid 99); 19 Oct 2012 15:24:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Oct 2012 15:24:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B058E1C00EA; Fri, 19 Oct 2012 15:24:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6022882761784164363==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2206: add a new optimizer for query correlation discovery and optimization From: "Yin Huai" To: "Yin Huai" , "hive" , "Carl Steinbach" Date: Fri, 19 Oct 2012 15:24:23 -0000 Message-ID: <20121019152423.16939.49876@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Yin Huai" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/7126/ X-Sender: "Yin Huai" References: <20121002154328.22634.80343@reviews.apache.org> In-Reply-To: <20121002154328.22634.80343@reviews.apache.org> Reply-To: "Yin Huai" --===============6022882761784164363== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7126/ ----------------------------------------------------------- (Updated Oct. 19, 2012, 3:24 p.m.) Review request for hive. Changes ------- update test results according to HIVE-3495 and update comments Description ------- This optimizer exploits intra-query correlations and merges multiple correl= ated MapReduce jobs into one jobs. Open a new request since I have been wor= king on hive-git. This addresses bug HIVE-2206. https://issues.apache.org/jira/browse/HIVE-2206 Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f86d6a7 = conf/hive-default.xml.template 4a59fb6 = ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Operato= rType.java 8c9bd26 = ql/src/java/org/apache/hadoop/hive/ql/exec/BaseReduceSinkOperator.java PR= E-CREATION = ql/src/java/org/apache/hadoop/hive/ql/exec/CorrelationCompositeOperator.j= ava PRE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/exec/CorrelationLocalSimulativeRedu= ceSinkOperator.java PRE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/exec/CorrelationReducerDispatchOper= ator.java PRE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/exec/ExecReducer.java 18a9bd2 = ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 652d81c = ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 587fe33 = ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java 0c22141 = ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 919a14= 0 = ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1469325 = ql/src/java/org/apache/hadoop/hive/ql/optimizer/CorrelationOptimizer.java= PRE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/optimizer/CorrelationOptimizerUtils= .java PRE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 01b07= 28 = ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 40cc7ed = ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 8bacd3d = ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java bdae9d5 = ql/src/java/org/apache/hadoop/hive/ql/plan/BaseReduceSinkDesc.java PRE-CR= EATION = ql/src/java/org/apache/hadoop/hive/ql/plan/CorrelationCompositeDesc.java = PRE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/plan/CorrelationLocalSimulativeRedu= ceSinkDesc.java PRE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/plan/CorrelationReducerDispatchDesc= .java PRE-CREATION = ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 5a9f064 = ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 16eb125 = ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 9a95efd = ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 142f040 = ql/src/test/queries/clientpositive/correlationoptimizer1.q PRE-CREATION = ql/src/test/queries/clientpositive/correlationoptimizer2.q PRE-CREATION = ql/src/test/queries/clientpositive/correlationoptimizer3.q PRE-CREATION = ql/src/test/queries/clientpositive/correlationoptimizer4.q PRE-CREATION = ql/src/test/queries/clientpositive/correlationoptimizer5.q PRE-CREATION = ql/src/test/results/clientpositive/correlationoptimizer1.q.out PRE-CREATI= ON = ql/src/test/results/clientpositive/correlationoptimizer2.q.out PRE-CREATI= ON = ql/src/test/results/clientpositive/correlationoptimizer3.q.out PRE-CREATI= ON = ql/src/test/results/clientpositive/correlationoptimizer4.q.out PRE-CREATI= ON = ql/src/test/results/clientpositive/correlationoptimizer5.q.out PRE-CREATI= ON = ql/src/test/results/compiler/plan/groupby1.q.xml 4382252 = ql/src/test/results/compiler/plan/groupby2.q.xml eef669c = ql/src/test/results/compiler/plan/groupby3.q.xml 9743480 = ql/src/test/results/compiler/plan/groupby5.q.xml 8e07860 = Diff: https://reviews.apache.org/r/7126/diff/ Testing ------- All tests pass. Thanks, Yin Huai --===============6022882761784164363==--