Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E6C6D0B4 for ; Thu, 4 Oct 2012 03:11:49 +0000 (UTC) Received: (qmail 75715 invoked by uid 500); 4 Oct 2012 03:11:48 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 75642 invoked by uid 500); 4 Oct 2012 03:11:47 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 75602 invoked by uid 99); 4 Oct 2012 03:11:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Oct 2012 03:11:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5CB3A1C0D9F; Thu, 4 Oct 2012 03:11:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1280710071311114844==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-3525 From: "Sean Busbey" To: "Sean Busbey" , "hive" Date: Thu, 04 Oct 2012 03:11:44 -0000 Message-ID: <20121004031144.22633.32957@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sean Busbey" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/7430/ X-Sender: "Sean Busbey" References: <20121003223748.22633.38520@reviews.apache.org> In-Reply-To: <20121003223748.22633.38520@reviews.apache.org> Reply-To: "Sean Busbey" --===============1280710071311114844== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7430/ ----------------------------------------------------------- (Updated Oct. 4, 2012, 3:11 a.m.) Review request for hive. Changes ------- Now includes a proposed fix, changing internal Hashtable use to HashMap. Summary (updated) ----------------- HIVE-3525 Description (updated) ------- Changes Avro SerDe to use HashMap when copying out the Avro Map to Map. fixes HIVE-3525. Diffs (updated) ----- /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer= .java 1393805 = /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserial= izer.java 1393805 = /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroObjectIn= spectorGenerator.java 1393805 = /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializ= er.java 1393805 = Diff: https://reviews.apache.org/r/7430/diff/ Testing (updated) ------- Includes unit tests for = * AvroObjectInspectorGenerator to verify that the Nullable value type is pr= esented as just the non-null type. * AvroDeserializer to verify that Maps with null are properly handled * AvroSerializer to verify that Maps with null can round trip. Thanks, Sean Busbey --===============1280710071311114844==--