hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request: HIVE-3528
Date Tue, 16 Oct 2012 13:08:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7431/
-----------------------------------------------------------

(Updated Oct. 16, 2012, 1:08 p.m.)


Review request for hive.


Changes
-------

Updated per notes on review. Also fixed the access on the shared String Schema and added some
comments to alleviate my nervousness about making it static.


Description
-------

Changes AvroSerDe to properly give the non-null schema to serialization routines when using
Nullable complex types


Diffs (updated)
-----

  /trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java 1398763 
  /trunk/serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java 1398763


Diff: https://reviews.apache.org/r/7431/diff/


Testing
-------

Adds tests that check each of the Avro types that Serialization needs to use a user-provided
schema, both as top level fields and as nested members of a complex type.


Thanks,

Sean Busbey


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message