hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yin Huai" <h...@cse.ohio-state.edu>
Subject Re: Review Request: HIVE-3495: For UDAFs, when generating a plan without map-side-aggregation, constant agg parameters will be replaced by ExprNodeColumnDesc
Date Mon, 01 Oct 2012 14:35:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7221/
-----------------------------------------------------------

(Updated Oct. 1, 2012, 2:35 p.m.)


Review request for hive.


Changes
-------

address Namit's comments.


Description
-------

Please see jira for detailed description


This addresses bug HIVE-3495.
    https://issues.apache.org/jira/browse/HIVE-3495


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java bce2a06 
  ql/src/test/queries/clientpositive/udaf_percentile_approx.q c436a63 
  ql/src/test/results/clientpositive/count.q.out 61e54c7 
  ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c 
  ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62 
  ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66 
  ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc 
  ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82 

Diff: https://reviews.apache.org/r/7221/diff/


Testing
-------

All tests pass.


Thanks,

Yin Huai


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message