Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC8119E8B for ; Tue, 11 Sep 2012 20:54:08 +0000 (UTC) Received: (qmail 41697 invoked by uid 500); 11 Sep 2012 20:54:08 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 41639 invoked by uid 500); 11 Sep 2012 20:54:08 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 41571 invoked by uid 500); 11 Sep 2012 20:54:08 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 41544 invoked by uid 99); 11 Sep 2012 20:54:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2012 20:54:08 +0000 Date: Wed, 12 Sep 2012 07:54:08 +1100 (NCT) From: "Zhenxiao Luo (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <488943133.65390.1347396848599.JavaMail.jiratomcat@arcas> In-Reply-To: <875017418.20260.1344321063067.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (HIVE-3339) Change the rules in SemanticAnalyzer to use Operator.getName() instead of hardcoded names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenxiao Luo updated HIVE-3339: ------------------------------- Attachment: HIVE-3339.1.patch.txt > Change the rules in SemanticAnalyzer to use Operator.getName() instead of hardcoded names > ----------------------------------------------------------------------------------------- > > Key: HIVE-3339 > URL: https://issues.apache.org/jira/browse/HIVE-3339 > Project: Hive > Issue Type: Bug > Reporter: Namit Jain > Priority: Minor > Attachments: HIVE-3339.1.patch.txt > > > This should be done for code cleanup. > Instead of the rule being: > SEL% > It should say SelectOperator.getName()% > It would make the rules more readable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira