hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Travis Crawford" <traviscrawf...@gmail.com>
Subject Re: Review Request: Add "SET" support to Hive serde
Date Thu, 27 Sep 2012 22:35:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7124/#review12008
-----------------------------------------------------------

Ship it!


Non-committer +1. This looks good Feng!

- Travis Crawford


On Sept. 15, 2012, 12:06 a.m., Feng Peng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7124/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2012, 12:06 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Dmitriy Ryaboy, and Travis Crawford.
> 
> 
> Description
> -------
> 
> Added SET support to Hive serde. Added unit tests based on the MegaStruct introduced
in https://issues.apache.org/jira/browse/HIVE-3323.
> 
> 
> This addresses bug HIVE-775.
>     https://issues.apache.org/jira/browse/HIVE-775
> 
> 
> Diffs
> -----
> 
>   ql/src/test/results/clientpositive/convert_enum_to_string.q.out 6cf1931 
>   serde/if/serde.thrift e40c697 
>   serde/src/gen/thrift/gen-cpp/serde_constants.h 94015c2 
>   serde/src/gen/thrift/gen-cpp/serde_constants.cpp 350521d 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.java 2c32999

>   serde/src/gen/thrift/gen-php/serde/serde_constants.php 99bda06 
>   serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py b9e01c1 
>   serde/src/gen/thrift/gen-rb/serde_constants.rb 7ef2fc9 
>   serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java e906a3f 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 20758a7 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySet.java PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 0036a8e 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
8fee0fc 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySetObjectInspector.java
PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspector.java d90560b

>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
7537e99 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
0e39073 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
bedc9dd 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SetObjectInspector.java
PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SettableSetObjectInspector.java
PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardConstantSetObjectInspector.java
PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardSetObjectInspector.java
PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/SetTypeInfo.java PRE-CREATION

>   serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 594f5ab

>   serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 6c07ab5 
>   serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestSetObjectInspectors.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Feng Peng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message